Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger provider openlineage tests after assets change #44026

Closed
potiuk opened this issue Nov 14, 2024 · 6 comments · Fixed by #44172
Closed

Trigger provider openlineage tests after assets change #44026

potiuk opened this issue Nov 14, 2024 · 6 comments · Fixed by #44172
Assignees
Labels
area:CI Airflow's tests and continious integration provider:openlineage AIP-53

Comments

@potiuk
Copy link
Member

potiuk commented Nov 14, 2024

When running selective checks, we should automatically trigger open-lineage provider tests (in main) in any PR that changes assets, as openlineage tests heavily rely on assets and are often broken after asset changes. Example #44025 fixing broken test:

Image

@potiuk potiuk converted this from a draft issue Nov 14, 2024
@dosubot dosubot bot added area:CI Airflow's tests and continious integration provider:openlineage AIP-53 labels Nov 14, 2024
@potiuk
Copy link
Member Author

potiuk commented Nov 14, 2024

cc: @vatsrahul1001 @uranusjr => we might fix it to happen automatically (this test was broken by #41325) but kind request - until when you add new fields to assets etc, plese add "full tests needed" to the PR :)

@gopidesupavan
Copy link
Member

Yeah running openlineage tests would be good :)

@vatsrahul1001
Copy link
Collaborator

@potiuk I will look into this

@potiuk potiuk moved this from Ready to In progress in CI / CD planned work Nov 14, 2024
@potiuk
Copy link
Member Author

potiuk commented Nov 14, 2024

assigned you @vatsrahul1001 !

@vatsrahul1001
Copy link
Collaborator

@potiuk, I was checking how selective checks work, and your comment helped me understand it better. Should we create a new FileGroupForCi.ASSET_FILES for all asset files and use it to trigger the open-lineage provider tests?

@potiuk
Copy link
Member Author

potiuk commented Nov 16, 2024

Yes. That's likely best idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:CI Airflow's tests and continious integration provider:openlineage AIP-53
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants