Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow resizing the dialog #34

Closed
paazmaya opened this issue Jan 22, 2015 · 12 comments
Closed

Allow resizing the dialog #34

paazmaya opened this issue Jan 22, 2015 · 12 comments

Comments

@paazmaya
Copy link

I seem to have too small screen resolution, since the dialog disappears.
Please allow resizing the dialog, with scroll bar and/or responsive positioning dialog elements.

@skjorn
Copy link
Collaborator

skjorn commented Jan 24, 2015

Can you be more specific about your resolution and how "the dialog disappears"? Screenshot maybe? What platform and PS version are you running?
Anyway, Ps dialogs do not support resizing and they do not handle re-layout too well. Also, Adobe constantly changes their UI framework from version to version and from platform to platform. So we're just using the common API and let the Ps do it's standard thing, and that's what you get.

@skjorn skjorn added the bug label Jan 24, 2015
@paazmaya
Copy link
Author

Mac OS X 10.9
Photoshop CC 2014
Screenshot soon...

@paazmaya
Copy link
Author

screenshot 2015-01-27 18 22 43

@antipalindrome
Copy link
Owner

You should now have the ability to resize the window. Do note that the layout isn't flexible and therefore items may get cut off, though the bottom of the window is purely informational and doesn't contain any functionality. I'll try looking more into being able to have the "options" area resize on content so that we save on white-space when we can.

Let me know if resize isn't working for you.

@paazmaya
Copy link
Author

Thank you, will try now

@paazmaya
Copy link
Author

@jschaf, Had a look at it, now the dialog can indeed be resized, but would it be possible to add scroll bars?

@antipalindrome
Copy link
Owner

I'm not jschaf but I will look into it. :)

@skjorn
Copy link
Collaborator

skjorn commented Jan 28, 2015

@hsw107 Um, not sure what the resizing of the window itself was supposed to achieve... Right now it looks like a real bug IMHO. But maybe you have a bigger plan for it.

@paazmaya I wonder why you even reported it. It doesn't look like it's limiting in any way. It's also clearly modified as we do not feature exporting top-level groups yet. What you have there is purely cosmetic, caused by Ps's inherent inability to properly layout UI elements. I don't see why we should bother to fix it (while even Adobe doesn't). A scrollbar would make it even clunkier and I'm definitely against it.

Let's see what Hanna can come up with. I would actually suggest disabling the resizing again and close this "bug" as "won't fix". It doesn't look that bad on the screenshot.

@antipalindrome
Copy link
Owner

@skjorn If a user has a smaller resolution and the dialog won't fit then we need the ability to make the entire dialog accessible. While it may be acceptable in this case, other users may have even smaller screens still. A scrollbar is in every use case more clunky than no scrollbar, but a scrollbar adds functionality and usability. Besides, if possible, I'd only have the scrollbar appear when the dialog is sized smaller.

The resize code I put in is only meant as a temporary work-around so that people could make the window smaller. It doesn't even look different if you don't resize the window. So I don't see it as "buggy".

While Adobe may share some fault here, it's not above us to make a dialog that can fit onto people's screen. The current dialog is large, no doubt about that. As I've mentioned above the better thing would be to have the "options" area resize to just the content inside of it, which would save a lot of space when we aren't using it.

If you have a better solution, let me know. But I'm against closing this without a proper solution. If you'd like to discuss this more we should take it to somewhere else, like Skype.

@paazmaya
Copy link
Author

paazmaya commented Jan 29, 2015

@hsw107 sorry about the wrong name used...

@skjorn As a first time user, I was worried that what might be hidden at the bottom, perhaps some options to be adjusted or even the "run" button, which was found on the top.

@skjorn
Copy link
Collaborator

skjorn commented Jan 29, 2015

@paazmaya A fair point.

@antipalindrome
Copy link
Owner

With version 2.0 the window is much smaller and should fit much better, closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants