Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export visible layers only #10

Closed
skjorn opened this issue May 22, 2014 · 11 comments
Closed

Export visible layers only #10

skjorn opened this issue May 22, 2014 · 11 comments

Comments

@skjorn
Copy link
Collaborator

skjorn commented May 22, 2014

I think there should be an option to export visible layers only. It should be relatively easy to implement using LayerComp. I'm more than happy to do it if I'm assured it will get to mainstream.

@antipalindrome
Copy link
Owner

You're welcome to add it. Unfortunately I've been too busy to make many improvements myself lately but if you make a request I'll be happy to review it, test it, and if it works as described, I'll integrate it.

@skjorn
Copy link
Collaborator Author

skjorn commented May 22, 2014

Peachy. Generally though, I'll be able to make these changes only if my pull request regarding Targa support gets in. There are a lot of changes (half of the file maybe) that will make other merges difficult, but I felt they were necessary. I had to make a step towards extensibility and maintainability.

So please review it at your earliest convenience and let me know whether you're going to go with it or not. (I'm open to modify it if you find any issues.)

@antipalindrome
Copy link
Owner

Alright, I'll try and find some time tonight to look at. Thanks for your work :)

@finscn
Copy link
Contributor

finscn commented Jun 1, 2014

@skjorn , I hope #12 could help you :)

@skjorn
Copy link
Collaborator Author

skjorn commented Jun 1, 2014

@finscn Thanks, but no. I've implemented most of the features myself already, so I'm just going my own path. I basically rewrote the whole script. That's the problem with people working separately instead of together -- you end up writing the same code again and again. Alas, it can't be helped in this case.

@finscn
Copy link
Contributor

finscn commented Jun 1, 2014

@skjorn , sorry , My english is very weak , so I can't know what do you mean .

A. you have implemented the feature "Export visible layers only" ,so you don't need my code
B. you hope I could submit the pull request
C. there are some things I did make you unhappy

@skjorn
Copy link
Collaborator Author

skjorn commented Jun 2, 2014

:-) I am perfectly happy and you did nothing wrong. In fact, you did an amazing job. It's A (I also added support for Targa). I just regret that there's no leader for the project -- a person who would actively maintain it and say what goes inside a widely available version, so it doesn't bloat. This script is a common problem. Many people could benefit from it. Instead they get to this version by hsw107 from Google and are not aware that there are more advanced forks out there. So the same features are implemented over and over again -- that's sad.

@antipalindrome
Copy link
Owner

They get to my version because I wrote the original version and yes, I'll be the first to admit I haven't been doing a great job maintaining it and I need to find the time to come up with a new version using the changes so many people have proposed.
Unfortunately I haven't had the time in a while as I've been moving into a new house and before that I had been out of the country for a while so I wasn't able to maintain it. Once my move in complete I fully intend to get the script updated with the best of everyone's changes and I sincerely apologize for the delay on everything.

@skjorn
Copy link
Collaborator Author

skjorn commented Jun 3, 2014

Hey, don't need to apologise. I didn't mean it as a rebuke to you; just commenting the reality. You don't owe us anything and I'm sincerely grateful you wrote the script and put it in here. Given the history it was rather unclear what's gonna happen to the project. But since you intend to maintain it, I guess my worries were premature.

@antipalindrome
Copy link
Owner

No need to maybe, but I want to apologize, I get behind on things sometimes. Honestly I kind of forgot to monitor it as much and hadn't realized the script became as popular as it did. Also, if you ever want to be a collaborator on the repository I'd be happy to do that as well if you're interested.

@skjorn
Copy link
Collaborator Author

skjorn commented Jun 3, 2014

Sure, that would be nice I guess. I'd like to collaborate. Although we need to find a way to communicate about changes or one day you will wake up and realise that you don't recognise your own script one bit :-)

@skjorn skjorn closed this as completed Jun 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants