Skip to content

Commit

Permalink
build: fix doctests, run cargo publish --dry-run (denoland#8689)
Browse files Browse the repository at this point in the history
Co-authored-by: Bartek Iwańczuk <[email protected]>
  • Loading branch information
ry and bartlomieju committed Dec 9, 2020
1 parent d492fb0 commit b6dd850
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 4 deletions.
10 changes: 9 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ jobs:
kind: bench
- os: ${{ github.repository == 'denoland/deno' && 'ubuntu-latest-xl' || 'ubuntu-18.04' }}
kind: lint
- os: ${{ github.repository == 'denoland/deno' && 'ubuntu-latest-xl' || 'ubuntu-18.04' }}
kind: publish-dry-run

# Always run master branch builds to completion. This allows the cache to
# stay mostly up-to-date in situations where a single job fails due to
Expand Down Expand Up @@ -217,7 +219,9 @@ jobs:

- name: Test debug
if: matrix.kind == 'test_debug'
run: cargo test --locked --all-targets
run: |
cargo test --locked --doc
cargo test --locked --all-targets
- name: Run Benchmarks
if: matrix.kind == 'bench'
Expand Down Expand Up @@ -264,6 +268,10 @@ jobs:
target/release/lib.deno.d.ts
draft: true

- name: Publish Dry Run
if: matrix.kind == 'publish-dry-run'
run: cd cli && cargo publish --dry-run

- name: Publish
if: |
startsWith(matrix.os, 'ubuntu') &&
Expand Down
2 changes: 1 addition & 1 deletion core/async_cell.rs
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ impl<T> RcRef<AsyncRefCell<T>> {
///
/// ```rust
/// # use std::rc::Rc;
/// # use deno_core::async_cell::RcRef;
/// # use deno_core::RcRef;
///
/// struct Stuff {
/// foo: u32,
Expand Down
4 changes: 2 additions & 2 deletions core/resources2.rs
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,8 @@ impl ResourceTable {
/// # Example
///
/// ```
/// # use deno_core::resources2::ResourceTable;
/// # let resource_table = ResourceTable::default();
/// # use deno_core::ResourceTable2;
/// # let resource_table = ResourceTable2::default();
/// let resource_names = resource_table.names().collect::<Vec<_>>();
/// ```
pub fn names(&self) -> impl Iterator<Item = (ResourceId, Cow<str>)> {
Expand Down

0 comments on commit b6dd850

Please sign in to comment.