Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any chance to upgrade critical to v4.0.0 ? #55

Open
gigo6000 opened this issue Jul 7, 2021 · 2 comments
Open

Any chance to upgrade critical to v4.0.0 ? #55

gigo6000 opened this issue Jul 7, 2021 · 2 comments

Comments

@gigo6000
Copy link

gigo6000 commented Jul 7, 2021

Hi, is this project abandoned? or is there any reason to not upgrade to the latest critical version (v4.0.0)

@thescientist13
Copy link
Collaborator

Hi @gigo6000

I have helped triage some PRs and answer issues, but I think the maintainer is indeed needed to sustain any forward momentum on this project (merging, tagging, publishing to npm) and I unfortunately don't have permissions for that. (or time if I did, as I'm managing a few of my own projects).

Thus, I can't speak for the maintainer but I think it may be worth considering this project archived effectively.

@gigo6000
Copy link
Author

gigo6000 commented Aug 17, 2021

Hi @thescientist13 thanks for the reply, we're now moving way from this project, in our case we actually didn't even need to include Critical in webpack/ webpack mix, generating the css from a simple JS is enough. Here's an example just in case anyone lands here and is curious: https://gist.github.com/gigo6000/9743475d1eb13794af0a17830b2f8a5a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants