Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the classification criterion doesn't factor in the uncertainty - does this mean ignore the uncertainty for classification? #20

Open
sgbaird opened this issue Jan 7, 2022 · 0 comments

Comments

@sgbaird
Copy link
Collaborator

sgbaird commented Jan 7, 2022

i.e. log_std is an unused parameter in the classification criterion:

CrabNet/utils/utils.py

Lines 263 to 265 in a5be06f

def BCEWithLogitsLoss(output, log_std, target):
loss = nn.functional.binary_cross_entropy_with_logits(output, target)
return loss

If this is the case, should the uncertainty output from CrabNet be ignored by the user during classification? In other words, are the uncertainty values essentially just a bunch of random numbers for classification?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant