Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AdditionalProperties not accepted by the current CRD Validation Spec #2

Closed
tamalsaha opened this issue Apr 1, 2018 · 3 comments
Closed

AdditionalProperties not accepted by the current CRD Validation Spec #2

tamalsaha opened this issue Apr 1, 2018 · 3 comments

Comments

@tamalsaha
Copy link
Contributor

Hi,
Thanks for this handy library. One question I have is why do you think additionalProperties field is not supported by Kubernetes ? This field seems to be present in Go type and present in kubernetes/kube-openapi tests.

crd-validation/pkg/convert_types.go

Line 120 in eabcf70

// @TODO(01-25-2018) Field not accepted by the current CRD Validation Spec

@tamalsaha
Copy link
Contributor Author

I filed a pr to fix the issue kubernetes/kubernetes#61991

@nikhita
Copy link

nikhita commented Apr 10, 2018

xref kubernetes/kubernetes#59485

@tamalsaha
Copy link
Contributor Author

Fixed in upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tamalsaha @nikhita