Skip to content
This repository has been archived by the owner on May 20, 2024. It is now read-only.

missing PR branch incorrectly implemented #1125

Open
jctanner opened this issue Dec 13, 2018 · 1 comment
Open

missing PR branch incorrectly implemented #1125

jctanner opened this issue Dec 13, 2018 · 1 comment
Assignees
Labels

Comments

@jctanner
Copy link
Contributor

jctanner commented Dec 13, 2018

14bc5dc#diff-b206352f3de977e805cb5daa6f314c53R765

  1. all of the code in ansible.py needs to be moved to a plugin file in triagers/plugins
  2. the return from the plugin should be facts that indicate if the comment should be added and if the issue should be closed
  3. the historywrapper should be used inside the plugin to check if the comment was already added
  4. the duplicate comments across all the PRs need to be removed docker_image: add network parameter ansible#45127
  5. the instructions in the message should be moved to docs.ansible and the comment can link to it.
@jctanner
Copy link
Contributor Author

#1126 temporarily turns off the codeblock

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants