Test batch tx events #3401
Merged
Test batch tx events #3401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3401 +/- ##
==========================================
- Coverage 53.92% 53.92% -0.01%
==========================================
Files 317 317
Lines 107575 107580 +5
==========================================
- Hits 58011 58010 -1
- Misses 49564 49570 +6 ☔ View full report in Codecov by Sentry. |
grarco
reviewed
Jun 12, 2024
| batch.header.chain_id = shell.chain_id.clone(); | ||
| batch.header.atomic = false; | ||
|
|
||
| // append first inner tx to batch (this one is valid) |
There was a problem hiding this comment.
Nit, we have a mk_tx_batch helper for unit tests in finalize_block that you could use to build the batch
Closed
brentstone
added a commit
that referenced
this pull request
Jun 12, 2024
* tiago/test-batch-tx-events: Changelog for #3401 Test inner tx results from batch tx Remove redundant TODO
brentstone
added a commit
that referenced
this pull request
Jun 14, 2024
* tiago/test-batch-tx-events: Changelog for #3401 Test inner tx results from batch tx Remove redundant TODO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #3397
Adds additional test coverage to batch tx events emission, to make sure we correctly build a batch of inner tx events from a batched tx.
Indicate on which release or other PRs this topic is based on
v0.39.0Checklist before merging to
draft