namada/vm: disable floats in wasm #3209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3209 +/- ##
==========================================
- Coverage 60.24% 60.24% -0.01%
==========================================
Files 303 303
Lines 93191 93191
==========================================
- Hits 56145 56143 -2
- Misses 37046 37048 +2 ☔ View full report in Codecov by Sentry. |
|
can we move ibc back to wasm now? |
@Fraccaman I'm not sure, it was an issue with M1/M2 which might still be there (#1831) |
4880921
to
7f3a04c
Compare
grarco
approved these changes
May 9, 2024
brentstone
added a commit
that referenced
this pull request
May 9, 2024
* tomas/disable-wasm-floats: changelog: add #3209 namada/vm: disable floats in wasm
|
@yito88 do u know if we can compile ibc-rs to wasm now? |
|
@Fraccaman I tried it in #2480 and it worked. I'm not sure whether the latest one works or not. I'll try it with 0.35.1 |
|
tx_ibc.wasm moved back to wasm worked in #3275 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
closes #1872
Indicate on which release or other PRs this topic is based on
0.35.1
Checklist before merging to
draft