Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functions to update token balance and supply #3029

Merged
merged 7 commits into from
May 9, 2024
Merged

Functions to update token balance and supply #3029

merged 7 commits into from
May 9, 2024

Conversation

brentstone
Copy link
Collaborator

@brentstone brentstone commented Apr 8, 2024 •
edited
Loading

Describe your changes

Indicate on which release or other PRs this topic is based on

v0.34.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@brentstone brentstone mentioned this pull request Apr 8, 2024
Closed
@brentstone brentstone force-pushed the brent/token-balance-update-fns branch from 2b7f9c9 to c9d970b Compare April 9, 2024 21:04
@Fraccaman Fraccaman mentioned this pull request Apr 15, 2024
Closed
@brentstone brentstone force-pushed the brent/token-balance-update-fns branch from c9d970b to c486d6f Compare April 22, 2024 22:06
@codecov Codecov
Copy link

codecov bot commented Apr 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.23353% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 59.40%. Comparing base (9d4de02) to head (9f32d08).
Report is 2 commits behind head on main.

Files Patch % Lines
crates/trans_token/src/storage.rs 83.50% 16 Missing ⚠️
...s/apps/src/lib/node/ledger/shell/finalize_block.rs 56.25% 7 Missing ⚠️
...rc/protocol/transactions/ethereum_events/events.rs 90.74% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3029      +/-   ##
==========================================
- Coverage   59.40%   59.40%   -0.01%     
==========================================
  Files         298      298              
  Lines       92326    92330       +4     
==========================================
- Hits        54849    54847       -2     
- Misses      37477    37483       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone brentstone force-pushed the brent/token-balance-update-fns branch from df934c2 to 9c47caf Compare April 27, 2024 01:14
@brentstone brentstone mentioned this pull request Apr 29, 2024
Closed
@brentstone brentstone force-pushed the brent/token-balance-update-fns branch from 7615492 to c39f3dc Compare May 2, 2024 06:28
@brentstone brentstone marked this pull request as ready for review May 2, 2024 06:28
@brentstone brentstone requested review from tzemanovic and sug0 May 2, 2024 06:30
@brentstone brentstone mentioned this pull request May 2, 2024
Closed
sug0
sug0 approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@sug0 sug0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! lgtm

crates/ethereum_bridge/src/protocol/transactions/ethereum_events/events.rs Show resolved Hide resolved
@brentstone brentstone requested a review from Fraccaman May 2, 2024 16:04
brentstone added a commit that referenced this pull request May 2, 2024
@brentstone
Merge branch 'brent/token-balance-update-fns' (#3029)
2f3e7ac
tzemanovic
tzemanovic approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@tzemanovic tzemanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat!

brentstone added a commit that referenced this pull request May 8, 2024
@brentstone
Merge branch 'brent/token-balance-update-fns' (#3029)
f616db4 
* origin/brent/token-balance-update-fns:
  changelog: add #3029
  update eth-bridge things
  better modularization
  better error handling
  use new fns in tests
  remove redundant genesis total supply initialization
  add functions in trans_token storage
@brentstone brentstone merged commit e1d6183 into main May 9, 2024
16 of 19 checks passed
@brentstone brentstone deleted the brent/token-balance-update-fns branch May 9, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sug0 sug0 sug0 approved these changes

@tzemanovic tzemanovic tzemanovic approved these changes

@Fraccaman Fraccaman Awaiting requested review from Fraccaman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add functions to update balances and token supplies Replace ad-hoc token transfer code with storage API code
3 participants
@brentstone @tzemanovic @sug0