Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Denomination for PGF over IBC #3085

Closed
yito88 opened this issue Apr 16, 2024 · 1 comment
Closed

Denomination for PGF over IBC #3085

yito88 opened this issue Apr 16, 2024 · 1 comment

Comments

@yito88
Copy link
Member

yito88 commented Apr 16, 2024

The handled denomination is different between regular PFG and PGF over IBC.
So, the denomination of the amount for PGF over IBC is confusing now. Regular PGF uses the default denomination of NAM, however, the one of an IBC transfer is always zero.

The amount in the logs is based on the default denomination on the source Namada.
The logs aren't correct because the funded amounts were 10 NAM (cPGF over IBC) and 5 NAM (rPGF over IBC).
The proposal's amounts were 10 and 5, and they imply zero denomination.

2024-04-15T19:26:58.340854Z  INFO namada_apps::node::ledger::shell::governance: Added/Updated ContinousPgf from proposal id 0: set 0.000010 to tnam1q9rhgyv3ydq0zu3whnftvllqnvhvhm270qxay5tn.
2024-04-15T19:26:58.341841Z  INFO namada_apps::node::ledger::shell::governance: Execute RetroPgf from proposal id 0: sent 0.000005 to tnam1q9sx4ekzqaq3xdxtruxkm764nhl00cvcsc7df5jf.

We should fix it to use the native token denomination for PGF over IBC too.

@Fraccaman
Copy link
Member

Done in #3092

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants