Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Borsh serialize all values written to storage #2868

Closed
sug0 opened this issue Mar 9, 2024 · 4 comments · Fixed by #3117
Closed

Borsh serialize all values written to storage #2868

sug0 opened this issue Mar 9, 2024 · 4 comments · Fixed by #3117
Assignees
Labels
enhancement New feature or request

Comments

@sug0
Copy link
Contributor

sug0 commented Mar 9, 2024

Currently, the raw bytes of some values in Namada (e.g. VP and TX wasm code) are written to storage instead of their borsh serialized byte array. This poses a challenge for the migration software in Namada, which checks the types of updated key:value pairs using their borsh deserializers.

We should encode all values in storage with borsh to fix these issues.

@sug0 sug0 added the enhancement New feature or request label Mar 9, 2024
@brentstone brentstone added this to the To evaluate milestone Apr 6, 2024
@cwgoes
Copy link
Contributor

cwgoes commented Apr 23, 2024

@yito88 could you take this on quickly?

@yito88 yito88 mentioned this issue Apr 23, 2024
2 tasks
@cwgoes
Copy link
Contributor

cwgoes commented Apr 24, 2024

@yito88 how long do you estimate is remaining here?

@yito88
Copy link
Member

yito88 commented Apr 24, 2024

@cwgoes done

@yito88
Copy link
Member

yito88 commented Apr 25, 2024

NOTE: Some IBC-related data are still not-borsh serialized because they should be proven for ICS-23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants