Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visit_duration is only used when using cookies - endless visits when using anonymity sets #526

Closed
zealot128 opened this issue Mar 15, 2023 · 1 comment

Comments

@zealot128
Copy link

zealot128 commented Mar 15, 2023

By grepping over the code base, It seems visit_duration is only applied when tracking via cookies.

When using Cookie-less tracking, all identical anonymity sets are munched together to one visit, even days apart.

We just had the experience of a conflicting user, which used the same browser, and the same masked-ip, but are days apart and where different people.

I propose, to:

  • mention that info in the README under visit_duration that it only applies to cookies
  • quickfix for us ATM: add the current date into the anonymity set - at least this helps a bit and don't group visits days apart.
  • or in DatabaseStore: somehow, make a new visit, when the duration of the current visit is over (last event < duration.ago age), but the visit_token is unique by default, and the visit_token is generated by the anonymity set mhmmmm..

This problems grows especially, as more browser want to reduce the information supplied in the user-agent so a collision will occur more frequently. Even so, the same user should also create a new session after some amount of time.

@zealot128
Copy link
Author

zealot128 commented Mar 15, 2023

Just saw a very similiar issue, but didn't found the title first.

#469

The problem is much more robust when using cookies, there is no time element at all, then. Not only when users with new landing pages etc, but even the same user after a couple of days.
We have spreads of 160+ days in one visit between started_at and max(time)...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant