This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Rename goog.provide from 'global' to 'globalNs' #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Closure Compiler change will begin special casing 'global' as it is a built-in in Node environments. See Google internal https://cl/270391864.
mprobst
approved these changes
Oct 8, 2019
|
@rkirov sonatype apparently has a hiccup again. Can we maybe disable the snapshot test to unblock changes while we move to internal first? |
|
Yes, but note that test_released doesn't really pass (green check-mark is showing because it is optional). Making released always pass is at odds with g3 passing tests after sync which runs at head only. Mostly because of golden tests against externs, we can't make a single golden pass against two versions of the JS compiler. The only way out I see is to prioritize moving to internal first clutz/gents development. |
|
For now, I removed the requirement of "ci/circleci: test_snapshot" passing, so that we can merge trivial changes like this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Closure Compiler change will begin special casing 'global' as it is native to Node environments. This causes issues when trying to goog.provide it. See also discussion on Google internal
https://cl/270391864.