-
Notifications
You must be signed in to change notification settings - Fork 27.5k
Make ErrorConstructor more robust for DataCloneError (v1.7.4) #16707
Comments
The Can you reliably reproduce the error? If so, it would be helpful to get more context about the actual error that is thrown. |
Well, since this only happens with the user agent Already have invested almost one hour deciphering that and am 99% sure it's a problem in Yes please, can you make it more fault tolerant pretty please? With more unit test coverages and try-catch blocks skipping the problematic values. |
With AngularJS having entered its LTS period, I am a little reluctant to make a change in order to solve a problem we don't fully understand. It would be nice to get more info on this. |
So it appears that something in your code is trying to pass the return value from a call to This is not a scenario that AngularJS supports. If you could find exactly where this was happening we could look into it, but otherwise there is not much more we can do. |
I hear you. Very difficult to debug or reproduce this scenario here. More weird is that this only happens with the facebookexternalhit user agent. |
Seeing lots of those errors in my app:
caused from user agent facebookexternalhit. After some examinations it turns out to happen inside the ErrorConstructor of v1.7.4 itself.
I think the constructor itself should be more stable when an error inside occurs, probably with a try-catch block. My guess is the
toDebugString()
fn which calls theserializeObject()
fn where this happens, where a cloning attempt is made and fails.There I would make the code more robust.
The text was updated successfully, but these errors were encountered: