Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: angular 18 #442

Closed
wants to merge 1 commit into from

Conversation

bastienmoulia
Copy link

Fix #441

Use control flow syntax.

@Jefiozie
Copy link
Member

Jefiozie commented Jun 2, 2024

hi @bastienmoulia thanks for the PR we appriciate the work you have put in.
To review this PR it would be handy if we have multiple commits with a set of changes. FOr example:

COmmit 1: update package file and runned migrations.
commit 2: convert code to new code flow
commit 3: fixed documentation

Based on the actions I think we also should do something about the tests as it looks like they are failing all atm.

@SanderElias
Copy link
Contributor

@bastienmoulia Thanks for your PR!
However, we have a competing one addressing more than flow control and a version bump.
because of that, and the failing tests, I'm going to close this one for now.

@SanderElias SanderElias closed this Jun 3, 2024
@Jefiozie
Copy link
Member

Jefiozie commented Jun 3, 2024

I totally missed that PR, thanks for your sharp eye @SanderElias

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular 18 update
3 participants