-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Divide ViewModelModule into several feature based module? #34
Labels
Comments
What you are saying is more than valid, but DI was out of scope and using Dagger is an implementation detail. With that being said we could use this issue to discuss about different approaches we can take regarding DI. |
I inherited ViewModelFactoryModule in different module to achieve it. It came quite hard to figure out injection could not be done unless one viewmodel injects in constructor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In a real-world app, there will be many features. Currently the
ViewModelModule
is responsible to provide all theViewModel
s, is it better that each feature gets itsViewModel
s from its own component instead of theApplicationComponent
?The text was updated successfully, but these errors were encountered: