Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about What is the best option?, Code Proposal #32

Open
Martindgadr opened this issue Jun 6, 2018 · 2 comments
Open

Question about What is the best option?, Code Proposal #32

Martindgadr opened this issue Jun 6, 2018 · 2 comments

Comments

@Martindgadr
Copy link
Contributor

Reading the code I got this and thought asking about what is the best option or if it's the same for the following code in order to learn a little more. For big gurus of Kotlin, what about using companion object or constructor in data clases or clases, for example, following code:

data class Movie(val id: Int, val poster: String) {

    companion object {
        fun empty() = Movie(0, String.empty())
    }
}

Vs. This Is what I used to use

  data class Movie(val id: Int, val poster: String) {
     constructor():this(0, String.empty())
  }
@ghost
Copy link

ghost commented Jun 6, 2018

@Martindgadr If i had to initialize an object then i will choose "default values"

data class Movie(val id: Int = 0, val poster: String = String.empty())

val movie = Movie()

)))

@jaychang0917
Copy link

jaychang0917 commented Jun 8, 2018

Static factory methods pattern is suggested in the Effective Java. However, in kotlin world, I agree with @VasileUngureanu :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants