-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat-Modif. Front formacionesPosgrado #206
base: master
Are you sure you want to change the base?
Conversation
cf4de4a
to
6070343
Compare
@@ -16,15 +16,23 @@ export class FormacionPosgradoAgregarComponent implements OnInit { | |||
|
|||
public cancel = false; | |||
profesiones: any[] = []; | |||
vencimientoAnio = (new Date()).getUTCFullYear() + 5; | |||
profesionalP: any = { | |||
fechaAlta = new Date(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya que estamos trabajando con la libreria moment() podriamos cambiar esa asignacion por fechaAlta = moment()
En caso de que sea necesario trabajarla en formato Date se puede asignar como fechaAlta = moment().toDate()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reemplacé 'new Date()' p/ 'moment().toDate()'
</td> | ||
</tr> | ||
</plex-table> | ||
<div *ngIf="!editarObtencion && !editarRevalida && !altaRevalida && !altaObtencion"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Al igual que en todos los *ngIf="..." cuando son bastantes extensos ya que se realizan multiples verificaciones, por buenas practicas, lo ideal seria armar una función en el .ts, llamarlo desde el html y que devuelva true o false si cumple con todas esas condiciones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cambié '*ngIf="!editarObtencion && !editarRevalida && !altaRevalida && !altaObtencion"' por funcion 'obtenerMatricula()'
* feat(MOBILE): configuracion de parametros con qr desde mobile * fix(MOBILE):Responsive listado guia profesional * ref(MOBILE): oculta filtros cuando viene la busqueda por parametro --------- Co-authored-by: aldoM <[email protected]> Co-authored-by: Lautaro Molina <[email protected]>
Cuando arroja el modal con un error de conexiòn es por la VPN. no conectada. |
Requerimiento
https://proyectos.andes.gob.ar/browse/MAT-137
Funcionalidad desarrollada
UserStory llegó a completarse
Requiere actualizaciones en la base de datos
Requiere actualizaciones en la API