Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert back to original currency when the extension is turned off. #15

Open
axispx opened this issue Aug 2, 2017 · 6 comments
Open

Comments

@axispx
Copy link

axispx commented Aug 2, 2017

No description provided.

@amitness
Copy link
Owner

amitness commented Aug 2, 2017

@prabinzz

@prabinzz
Copy link
Contributor

prabinzz commented Aug 2, 2017

Yes, it is possible but it will create alot of issues like.

  • Multi currency system will not work while reverting changes.
  • Changes are made directly in the DOM so, Prices which are originally in Rs. can't be detected.

However, Refreshing page automatically after turning off extenction will work.

@axispx
Copy link
Author

axispx commented Aug 2, 2017

@prabinzz how about auto refreshing the page when the extension is turned off?

Update: Sorry for the confusion. As you said auto refreshing the page when the extension is turned off is the way to go.

@prabinzz
Copy link
Contributor

prabinzz commented Aug 2, 2017

@anarchyrucks That should work. Or we can show original price along with converted price.

something like : $1 to Rs.102($1)

@axispx
Copy link
Author

axispx commented Aug 2, 2017

Why not both with an option to whether to show super text or not? 😄

@prabinzz
Copy link
Contributor

prabinzz commented Aug 2, 2017

Sounds well, We will work on that. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants