Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Suggestion in search result #57

Open
quyctd opened this issue Jan 19, 2022 · 6 comments
Open

[Suggestion] Suggestion in search result #57

quyctd opened this issue Jan 19, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@quyctd
Copy link

quyctd commented Jan 19, 2022

Thank you for creating a great tool. I fall in love with it right after the first try.

I think the tool can be better if directly showing the search suggestion in the results. Like the way we search in the Chrome address bar.
Screen Shot 2022-01-19 at 15 47 37

Not sure is it possible, but I think it'll be very helpful :D

@quyctd quyctd changed the title [Suggestion] Searching result [Suggestion] Suggestion in search result Jan 19, 2022
@alyssaxuu
Copy link
Owner

Yeah I could add a pseudoelement to show the suggestions inline.

The problem though is with the current set up. Right now the first result is a search action for your query, whatever it is. Should the order be switched and have the first entry be the best match from within Omni's results?

@alyssaxuu alyssaxuu added the enhancement New feature or request label Jan 19, 2022
@quyctd
Copy link
Author

quyctd commented Jan 19, 2022

I think the best match show first will be better; then the second is my search query

@alyssaxuu
Copy link
Owner

I think the best match show first will be better; then the second is my search query

To be clear, best match within tabs / bookmarks / actions... and not best match as in the same autofill suggestion in Chrome's omnibar? I don't think I can make it autofill like in the image above, I could do so for websites (using the browser history), but for specific search queries I would need to use Google's API directly.

Might want to see what people think about this specifically though before making any changes.

@quyctd
Copy link
Author

quyctd commented Jan 19, 2022

Here is my idea:

Normally, if I type to the search box, I prefer the best match in all cases, including tabs/bookmarks/actions/history/search, etc. But it may hurt the performance, I think.

If I know that I want to search, I think a shortcut like /s or /search will be helpful. Like the way you're currently allowed for /tabs, /actions.

@alyssaxuu
Copy link
Owner

I could look into it. I just don't want it to conflict with #40 and and #25. I guess if the input is a URL the top action could be to open it, otherwise only show actions within the Omni? I guess I could move search into its own command, true.

@quyctd
Copy link
Author

quyctd commented Jan 20, 2022

Yes, I think if the input is URL, then opening it makes sense.

In my case, I usually do not type the entire URL, mainly using some first letter and waiting for the suggestion, so I think we can count it as 2 separate use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants