Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when using pyFAMSA #4

Open
maovshao opened this issue Jun 3, 2024 · 2 comments
Open

Crash when using pyFAMSA #4

maovshao opened this issue Jun 3, 2024 · 2 comments

Comments

@maovshao
Copy link

maovshao commented Jun 3, 2024

Hi @althonos,

I am writing to express my gratitude for the updates on scoring-matrices in Version 0.4.0. The enhancements have been incredibly beneficial.

I have also noticed your attempts to resolve the crash bug as seen in refresh-bio/FAMSA#46 and refresh-bio/FAMSA#47. Unfortunately, it appears this Pull Request has not yet garnered the anticipated response.

Given that Pyfamsa is a standalone project built using Cython, I wonder if it would be possible to merge this PR into the Pyfamsa's famsa source code and then recompile with Cython. This could potentially provide a swift resolution to the problem at hand.

As a devoted user of Pyfamsa, I offer this suggestion in the hopes of furthering the progress and success of this project. I genuinely wish for the continued growth and improvement of both Pyfamsa and your team.

Best.

@agudys
Copy link

agudys commented Jun 3, 2024

Hello @maovshao ,

Martin's pull requests are actually not the solutions of the reported crashes (though, they should have been accepted quite ago - sorry Martin ;)). I'll try to take a look at this and incorporate a fix into FAMSA in a few days.

Best,
Adam

@maovshao
Copy link
Author

maovshao commented Jun 4, 2024

Sorry, my bad to misunderstand. Also, I'm more than happy to see your quick reply.

Looking forward to your update.

Best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants