Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment workflow enhancement #342

Closed
neerajgangwar opened this issue Jul 9, 2021 · 5 comments
Closed

Deployment workflow enhancement #342

neerajgangwar opened this issue Jul 9, 2021 · 5 comments

Comments

@neerajgangwar
Copy link
Contributor

neerajgangwar commented Jul 9, 2021

The deployment workflow currently uses two sets of branches:

  1. For the project pages: master branch for the source code and gh-pages branch for the generated website.
  2. For personal or organization webpages: source branch for the source code and gh-pages branch for the generated website.

Describe the solution you'd like
The above-mentioned behavior can be unified. For both use cases, master can be used for the source code and gh-pages can be used for deployment.

Describe alternatives you've considered
NA

Additional context
NA

@neerajgangwar
Copy link
Contributor Author

I have raised a PR for this - #344.

@ivanpuhachov
Copy link
Contributor

Hi! I was following the previous instruction and source branch, and after sync with upstream, github actions are no longer triggered. What should I do to fix it?

@ivanpuhachov
Copy link
Contributor

Fixed it.

  1. .github/workflows/deploy add source to the branches:
on:
  push:
    branches:
      - master
      - source
  1. On Github - repo - Settings - Pages select gh-pages as a source branch – as it is written in current readme file. In old instructions it was master

@neerajgangwar
Copy link
Contributor Author

neerajgangwar commented Aug 21, 2021

Yes, this is one way. But the idea was to have source code in the master branch. So you could also do the following:

  1. Delete the master branch.
  2. Rename source to master.
  3. Push all the future changes to master. The generated site will be pushed to gh-pages which should be selected as the source branch in publishing source.

@ivanpuhachov
Copy link
Contributor

Got it, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants