Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: iamjackg/md2cf
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: alphagov/md2cf
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 9 commits
  • 4 files changed
  • 3 contributors

Commits on Jun 22, 2023

  1. Root directory must be in pythonpath otherwise relative imports fail 

    - relative imports within the tests module rely on the project root being in the pythonpath
- whether this happens automatically via pip install --editable seems to have changed
- see pypa/pip#12094 for the bug report on pip
- see #80 for more commentary
    @galund
    galund committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    1da5cf2 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. Merge pull request #2 from alphagov/fix-test-pythonpath 

    Root directory must be in pythonpath otherwise relative imports fail
    @galund
    galund authored Jun 23, 2023
    Configuration menu
    Copy the full SHA
    5c80a92 View commit details
    Browse the repository at this point in the history

  2. Allow .pages file at top level as well as in subdirectories 

    - side effect is that pages files could in principle override "collapse-single-pages" directive
    @galund
    galund committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    989c16b View commit details
    Browse the repository at this point in the history

  3. Remove now-redundant setting of variable outside main loop

    @galund
    galund committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    2a84fe7 View commit details
    Browse the repository at this point in the history

  4. Simplify logic and explain what each variable is for 

    - remove redundant if statement
    @galund
    galund committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    8e64d16 View commit details
    Browse the repository at this point in the history

  5. Improve readability by removing continue statements 

    (Commit message change to trigger workflow)
    @galund
    galund committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    da62deb View commit details
    Browse the repository at this point in the history

  6. Merge pull request #1 from alphagov/allow-pages-top-level 

    Allow pages top level
    @galund
    galund authored Jun 23, 2023
    Configuration menu
    Copy the full SHA
    a016c51 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. Recently, Confluence has been intermittently returning a 500 error, b… 

    …ut retrying usually resolves it.
    @munhitsu
    munhitsu committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    0092051 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #3 from alphagov/retry-on-500 

    retry on 500
    @munhitsu
    munhitsu authored Oct 11, 2023
    Configuration menu
    Copy the full SHA
    317456f View commit details
    Browse the repository at this point in the history
Loading