Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a picture per product #49

Closed
vinyll opened this issue Mar 24, 2021 · 7 comments
Closed

Allow a picture per product #49

vinyll opened this issue Mar 24, 2021 · 7 comments

Comments

@vinyll
Copy link
Contributor

vinyll commented Mar 24, 2021

In most cases a consumer want to see what the product looks like.
A picture's worth a thousand words.

@almet
Copy link
Owner

almet commented Mar 25, 2021

Hey, that's a nice idea. My experience of this is that most of the time we don't have pictures to put, and I in fact removed this from previous code because it seemed useless.

But that's not to say it shouldn't be here :-) If you feel it's useful to you, feel free to add this to the codebase and issue a pull request!

Cheers 👍

@vinyll
Copy link
Contributor Author

vinyll commented Mar 25, 2021

I'll lookup the code that was allowing pictures, that's a strong restriction for us here not to have that option.
Thanks for the precious info so I don't have to code what was coded already :)

@almet
Copy link
Owner

almet commented Mar 25, 2021

I hope you'll be able to find it in the commit mess… Two hints:

Also, I remember this was just done with urls, and not with an actual import of files, which might not be what you want here. So you might need to code it yourself if that's not what you want :/

@vinyll
Copy link
Contributor Author

vinyll commented Mar 25, 2021

The best would be to have an external service that would permit a widget in the web page that uploads to that service.
That would return the URL…
#dreaming

@vinyll
Copy link
Contributor Author

vinyll commented Mar 25, 2021

I'm thinking of https://github.com/uploadcare for now as I don't feel like redeveloping an image uploader and hosting.
It's not perfect to me as I can't find the server scripts for hosting, however it would do the job.
Maybe I'd do that in a branch that would not end up into a PR. #suggestionsarewelcome

@almet
Copy link
Owner

almet commented Mar 25, 2021

That seems nice enough :-) I'll be happy to try things out and comment :-)

@almet
Copy link
Owner

almet commented Jul 29, 2021

Hey, I'm closing this, don't hesitate to reopen if you intend to work on it :-)

@almet almet closed this as completed Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants