Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes in minor version? #32

Closed
alex-philippov opened this issue Mar 14, 2023 · 3 comments · Fixed by #33
Closed

Breaking changes in minor version? #32

alex-philippov opened this issue Mar 14, 2023 · 3 comments · Fixed by #33
Assignees

Comments

@alex-philippov
Copy link

alex-philippov commented Mar 14, 2023

We have version 1.1.1 in our project. After update to 1.2.0 we got an error
Снимок экрана 2023-03-14 в 08 37 25

@princebansal
Copy link
Contributor

Thanks for writing to us. We will look into the issue. Meanwhile can you use the previous version to avoid any production degradations.

@chandrabezzo
Copy link
Contributor

@DK070202 I think better to implement deprecated warning first before breaking changes.

@DK070202
Copy link
Contributor

DK070202 commented Mar 16, 2023

We have version 1.1.1 in our project. After updating to 1.2.0 we got an error

@DK070202 I think it is better to implement a deprecated warning first before breaking changes.

Thanks, for choosing the Growthbook and for this feedback.

Yes, I do agree when changes are going to be breaking changes, will incorporate such warnings in the future version before such major changes. With that, we are going to roll out a new major version of SDK 2.0.0 that partially solves this. As package publishing process on the pub is an irreversible process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants