Fixes and CMake support

[Prince213]

No description provided.

[aligrudi]

Hi, Sizhe Zhao ***@***.***> wrote:

You can view, comment on, or merge this pull request online at: #2 -- Commit Summary -- * roff: fix use of fprintf * roff: fix warnings * CMakeLists.txt: support building with CMake

Sorry for the long delay. I was very busy lately. Personally I do not like cmake. Other changes I shall cherry pick. Ali

[Prince213]

@aligrudi To be honest I don't like CMake either (weird syntax), but it has become some standard and really saves the hassle of maintaining build files for environments such as Visual Studio.

[Alhadis]

@Prince213 Supporting two different build systems for the same project is unwise, IMHO. Any updates to Neatroff's Makefile will likely need to be reflected in CMakeLists.txt (and vice versa).

saves the hassle of maintaining build files for environments such as Visual Studio.

What exactly does that involve, just out of curiosity?

[polluks]

I get these warnings:

cc -c -Wall -O2 "-DTROFFFDIR=\"/neatroff/font\"" "-DTROFFMDIR=\"/neatroff/tmac\"" dev.c
dev.c: In function 'dev_mnt':
dev.c:62:35: warning: '/dev' directive output may be truncated writing 4 bytes into a region of size between 1 and 1024 [-Wformat-truncation=]
   snprintf(path, sizeof(path), "%s/dev%s/%s", dev_dir, dev_dev, name);
                                   ^~~~
dev.c:62:3: note: 'snprintf' output 6 or more bytes (assuming 2052) into a destination of size 1024
   snprintf(path, sizeof(path), "%s/dev%s/%s", dev_dir, dev_dev, name);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc -c -Wall -O2 "-DTROFFFDIR=\"/neatroff/font\"" "-DTROFFMDIR=\"/neatroff/tmac\"" reg.c
reg.c: In function 'num_str':
reg.c:114:21: warning: '%s' directive writing up to 1023 bytes into a region of size 128 [-Wformat-overflow=]
    sprintf(numbuf, "%s", directory(in_filename()));
                     ^~
reg.c:114:4: note: 'sprintf' output between 1 and 1024 bytes into a destination of size 128
    sprintf(numbuf, "%s", directory(in_filename()));
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[polluks]

By the way why are issues disabled for this repo?
https://www.reddit.com/r/groff/comments/qrfvkh/fractions_in_neatroff/?rdt=53160

[aligrudi]

Stefan ***@***.***> wrote:

By the way why are issues disabled for this repo? https://www.reddit.com/r/groff/comments/qrfvkh/fractions_in_neatroff/?rdt=53160

I remember discussing a similar problem via email. This was confirmed to work: .. Do you mean the horizontal distance between \(ru glyphs? The widths that come with the font do not seem exact. One solution may be to make Neatroff use this glyph from another font. ``` .fmap R ru ignoreit ``` Ali

[aligrudi]

Stefan ***@***.***> wrote:

I get these warnings: ``` cc -c -Wall -O2 "-DTROFFFDIR=\"/neatroff/font\"" "-DTROFFMDIR=\"/neatroff/tmac\"" dev.c dev.c: In function 'dev_mnt': dev.c:62:35: warning: '/dev' directive output may be truncated writing 4 bytes into a region of size between 1 and 1024 [-Wformat-truncation=] snprintf(path, sizeof(path), "%s/dev%s/%s", dev_dir, dev_dev, name); ^~~~ dev.c:62:3: note: 'snprintf' output 6 or more bytes (assuming 2052) into a destination of size 1024 snprintf(path, sizeof(path), "%s/dev%s/%s", dev_dir, dev_dev, name); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc -c -Wall -O2 "-DTROFFFDIR=\"/neatroff/font\"" "-DTROFFMDIR=\"/neatroff/tmac\"" reg.c reg.c: In function 'num_str': reg.c:114:21: warning: '%s' directive writing up to 1023 bytes into a region of size 128 [-Wformat-overflow=] sprintf(numbuf, "%s", directory(in_filename())); ^~ reg.c:114:4: note: 'sprintf' output between 1 and 1024 bytes into a destination of size 128 sprintf(numbuf, "%s", directory(in_filename())); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Fixed the last two. Thanks, Ali