fix(#12333): fixed auth Plugin resource parser can't parser v2 config openAPI namespaceId. #12336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KomachiSion
reviewed
Jul 15, 2024
| @@ -31,8 +32,11 @@ public class ConfigHttpResourceParser extends AbstractHttpResourceParser { | |||
|
|
|||
| @Override | |||
| protected String getNamespaceId(HttpServletRequest request) { | |||
| return NamespaceUtil.processNamespaceParameter(request.getParameter("tenant")); | |||
|
|
|||
| String namespaceId = request.getParameter(Constants.TENANT); | |||
There was a problem hiding this comment.
考虑到不影响原有的逻辑，所以先取的tenant，如果后面主推NAMESPACE_ID的话，换一下也行
There was a problem hiding this comment.
已调整，以 NAMESPACE_ID 优先
… config openAPI namespaceId. fix(alibaba#12333): fixed auth Plugin resource parser can't parser v2 config openAPI namespaceId.
KomachiSion
approved these changes
Jul 18, 2024
lowezheng
added a commit
to lowezheng/nacos
that referenced
this pull request
Jul 24, 2024
…apexsoft * commit '197795a854992d3f88824e4cdde34c61d8f56cf4': (225 commits) Fix alibaba#12395, use request context replace session depend. (alibaba#12398) Revert "Add an id primary key column to both the roles and permissions tables.（mysql-schema.sql） (alibaba#12206)" (alibaba#12396) Upgrade to 2.4.0 (alibaba#12384) Develop support ram info switch (alibaba#12382) Close derby ops api default. (alibaba#12372) Upgrade grpc to 1.64.2 (alibaba#12369) fix(alibaba#12333): fixed auth Plugin resource parser can't parser v2 config openAPI namespaceId. (alibaba#12336) Adjust integration tests for common modules in the core module to comply with checkstyle. (alibaba#12349) [IT]Adjust integration tests for cluster,code,smoke modules in the core module to comply with checkstyle. (alibaba#12350) fix [ISSUE alibaba#12323] , using the project's logback packagingData configuration instead of logback-nacos.xml's packagingData configuration (alibaba#12360) Remove the accessToken from the URL. (alibaba#12353) feat(alibaba#12355): Record the cost of ConfigDump in Prometheus. (alibaba#12356) [IT]Adjust core module auth integration tests to meet checkstyle requirements. (alibaba#12368) [ISSUE alibaba#12282]Fix the issue where monitoring data cannot be found through the IP dimension in the ListeningQuery (alibaba#12315) Adjust integration tests for ability, base, and client modules in the core module to comply with checkstyle. (alibaba#12335) Develop refactor request context (alibaba#12331) fix unexpect exception from NetworkInterface.ifUp (alibaba#12325) fix(alibaba#12231): When inserting and updating configurations in the database, the time-related field values need to be set using the time obtained from the database's built-in time function. (alibaba#12244) add some UT for default auth plugin (alibaba#12318) [ISSUE alibaba#12219] 修复nacos-client中config的ServerListManager解析endpoint失败问题 (alibaba#12220) ... # Conflicts: # plugin-default-impl/nacos-default-auth-plugin/src/main/java/com/alibaba/nacos/plugin/auth/impl/persistence/ExternalPermissionPersistServiceImpl.java # pom.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
fix(#12333 ): fixed auth Plugin resource parser can't parser v2 config openAPI namespaceId.
Brief changelog
fix(#12333 ): fixed auth Plugin resource parser can't parser v2 config openAPI namespaceId.
Verifying this change
fix(#12333 ): fixed auth Plugin resource parser can't parser v2 config openAPI namespaceId.