-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Naming Convention for Unit Test Classes in the Test Module. #12283
Comments
Test module is IT, not unit test. But the code style might be adjust it. |
Got it, it's an IT. Can I adjust the code style to use camel case naming? |
The IT contains so many old version code style from starting opensource, If change the code style will cause many changes. If you want to do this issue, I suggest you submit PR by packages or It cases so that each PR not contains so many changes. And need you to make sure the test logic is not changed. |
Get |
@stone-98 report some problem in module test
|
Thank you, I think this proposal is very good. The integration tests are divided into three modules: config, naming, and core. I will use ConfigITCase, NamingITCase, and CoreITCase respectively. What do you think? |
LGTM |
Describe the bug
Why are the names of unit test classes in the test module using the underscore naming convention? This does not comply with the checkstyle plugin's standards. Should we adjust it?
Expected behavior
The unit test class names in the test module follow the camel case naming convention.
Actually behavior
The unit test class names in the test module currently follow the underscore naming convention.
How to Reproduce
non.
Desktop (please complete the following information):
Additional context
non.
The text was updated successfully, but these errors were encountered: