fix(tags): write an annotated git tag #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some other tools like `git describe` (used by lerna) will only return annotated tags. As well, the git documentation ([link](https://git-scm.com/book/en/v2/Git-Basics-Tagging)) primarily documents writing annotated tags. This commit changes the behaviour of tags written by shipjs to write annotated tags
dhayab
reviewed
Jan 9, 2023
dhayab
approved these changes
Jan 9, 2023
|
This release is causing issue while creating git tags:
|
|
We updated the documentation right after to clarify that you need credentials :) #991. As shipjs is in prerelease this wasn't a breaking change, hope you understand! |
|
:smh: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some other tools like
git describe(used by lerna) will only return annotated tags. As well, the git documentation (link) primarily documents writing annotated tags.This commit changes the behaviour of tags written by shipjs to write annotated tags