Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke shipjs prepare from GitHub #346

Closed
uetchy opened this issue Oct 20, 2019 · 5 comments · Fixed by #502
Closed

Invoke shipjs prepare from GitHub #346

uetchy opened this issue Oct 20, 2019 · 5 comments · Fixed by #502

Comments

@uetchy
Copy link
Contributor

uetchy commented Oct 20, 2019

shipjs trigger can be automated thanks to CI.
To achieve frictionless release flow within the GitHub interface, shipjs prepare must also be able to be invoked without manually typing the CLI command from someone's PC.

Possible solution

  1. Invoke shipjs prepare when someone responsible for releasing process and granted for running it (basically, admin) comments @shipjs prepare in an issue or PR.
  2. Offer simple Web UI (like Dependabot) to provide the Prepare Release button.
  3. (any thoughts?)
@eunjae-lee
Copy link
Contributor

https://github.com/algolia/shipjs/blob/master/.circleci/config.yml#L69

You already can run shipjs prepare without interaction :) It's not yet documented well.
What do you think? Do you see any improvements to be made there?

@uetchy
Copy link
Contributor Author

uetchy commented Oct 23, 2019

@eunjae-lee That's awesome!
It's great if we have a way to manually initiate that process by commenting particular string on Issue/PR, in addition to scheduled release.

@eunjae-lee
Copy link
Contributor

@uetchy yes! If we don't have to type shipjs prepare and just press a button, it'd be fantastic.

I thought about what you said, and I feel like we need to have some sort of server or whatever to monitor the comments or at least receive and handle webhooks from GitHub if there're any.
Not sure if it can be done without servers or anything. Do you have any idea?

@KnisterPeter
Copy link

@eunjae-lee Github Actions could react on comments in issues or PRs.

@uetchy
Copy link
Contributor Author

uetchy commented Oct 27, 2019

@eunjae-lee @KnisterPeter
I've been thinking about that. Maybe we can do that on GitHub Actions, without concerning maintaining servers:

on:
  issue_comment:
    types: created
jobs:
  manual_release:
    if: |
      github.event_name == 'issue_comment' &&
      (github.event.comment.author_association == 'member' || github.event.comment.author_association == 'owner') &&
      startsWith(github.event.comment.body, '@shipjs prepare')
    runs-on: ubuntu-latest
    steps:
      - run: shipjs prepare

In that case, however, we have to resolve #316 first to ensure shipjs is compatible with GitHub Actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants