Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable DTLS fingerprint verification #549

Open
UE2020 opened this issue Jul 26, 2024 · 1 comment
Open

Disable DTLS fingerprint verification #549

UE2020 opened this issue Jul 26, 2024 · 1 comment

Comments

@UE2020
Copy link
Contributor

UE2020 commented Jul 26, 2024

It seems that it was possible to disable DTLS fingerprint verification at some point (at least v0.2.0), but now the fingerprint_verification config option doesn't go anywhere after Rtc::new_from_config is called. The old implementation wrapped output.push_back(DtlsEvent::RemoteFingerprint(fingerprint)); (here) in an if statement:

if self.fingerprint_verification {
    self.events
        .push_back(DtlsEvent::RemoteFingerprint(fingerprint));
}

Could this be added back?

@algesten
Copy link
Owner

Must have been a victim of the DTLS/crypto refactoring we did a while back. Let's add it back. PR welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants