Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use proper Docker secrets for the API token #44

Closed
alexpovel opened this issue Aug 21, 2022 · 1 comment
Closed

Use proper Docker secrets for the API token #44

alexpovel opened this issue Aug 21, 2022 · 1 comment
Assignees
@alexpovel
Labels
enhancement New feature or request
Milestone
anc.v1

Comments

@alexpovel
Copy link
Owner

Proper Docker secrets integrate well with Google Cloud Run as well, and are better suited than environment variables.
@alexpovel alexpovel self-assigned this Aug 21, 2022
@alexpovel alexpovel added the enhancement New feature or request label Aug 21, 2022
@alexpovel alexpovel added this to the anc.v1 milestone Aug 21, 2022
@alexpovel
Copy link
Owner Author

The token was moved to Google's Secret Manager and exposed from there as an environment variable to the service:

Screenshot 2022-09-03 130544

This gets us proper secrets management (it's recognized as a secret and therefore possibly redacted from logs etc (didn't test this)), while keeping the simplicity of environment variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexpovel alexpovel

Labels
enhancement New feature or request
Projects
None yet
Milestone
anc.v1
Development

No branches or pull requests
1 participant
@alexpovel