-
-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streaming example in docs/streaming.rst adding wrong handler #114
Comments
Looks like the bug in the docs has actually been fixed already here: I moved the add_handler call outside of read_stream to help users who want to reconnect to the stream if it fails. It gives them a little bit better base to start from. It also prevents a potential race condition where nasdaq_book_subs could send data faster than the handler could actually get registered. |
The original issue has been resolved. Please feel free to reopen an issue for your other concern. |
Description of Bug
The example listed in docs/streaming.rst will not display any data because it is subscribing to nasdaq_book_subs but adding a handler for add_timesale_options_handler. Also recommend re-organizing the code to make it a bit easier to reconnect to the Websocket without re-adding handlers.
Expected Behavior
Expected example to add handler to: add_nasdaq_book_handler
Actual Behavior
No data is generated
The text was updated successfully, but these errors were encountered: