New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrackRemoved Signal takes incorrect input #2

Closed

yashBhosale opened this issue Dec 11, 2020 · 2 comments

Contributor

yashBhosale commented Dec 11, 2020 •

edited

Loading

Hi, in https://github.com/alexdelorenzo/mpris_server/blob/master/mpris_server/tracklist.py the trackremoved signal inputs/outputs an array of object paths, when the spec https://specifications.freedesktop.org/mpris-spec/latest/Track_List_Interface.html says it's supposed to emit just one object path.

Contributor Author

yashBhosale commented Dec 11, 2020

As far as I can tell, the fix is just to change the signature of the signal in the xml, I can make the change and file a pull request for it.

yashBhosale mentioned this issue

Changing the signature for signal TrackRemoved #3

Merged

Owner

alexdelorenzo commented Dec 12, 2020

Good catch, thanks for submitting a pull request. I've merged it with the main branch.

yashBhosale closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment