-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is this bloom filter threadsafe? #56
Comments
I wrote a short program to try to find incorrect behavior in the presence of multiple threads, and it unfortunately appears to find some. I think that counts as a witness proof that the bloom filter is not thread-safe. Looking at the implementation: the backing array would need to use atomic operations like bloom-filter-scala/bloom-filter/src/main/scala/bloomfilter/mutable/UnsafeBitArray.scala Lines 19 to 26 in b2c41c0
|
Will there be a thread-safe implementation of this Bloom filter ? |
That is, is calling
.add
and.mightContain
concurrently from many different threads going to work?The text was updated successfully, but these errors were encountered: