Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Last project bookmark cannot be removed #422

Closed
ciscoheat opened this issue Apr 10, 2021 · 3 comments
Closed

[BUG] - Last project bookmark cannot be removed #422

ciscoheat opened this issue Apr 10, 2021 · 3 comments
Labels
Milestone

Comments

@ciscoheat
Copy link

  • Extension version: 13.0.4
  • VSCode version: 1.55.0
  • OS version: Win 10

Steps to reproduce

  1. Set "bookmarks.saveBookmarksInProject": true
  2. Add bookmarks
  3. Remove them

What happens: The last bookmark is still kept in bookmarks.json. According to the panel, no bookmarks exists, but when closing and opening VS Code, the last one appears again.

@ciscoheat ciscoheat added the bug label Apr 10, 2021
@alefragnani
Copy link
Owner

Hi @ciscoheat ,

First of all, sorry for the delay. It's been a busy period these days.

I could reproduce the error. It also happens not only using the Delete command in the Side Bar, but also with the Clearcommand in the Command Palette. Really weird to be failing on this scenario.

I'll take a look and hopefully fix this for the next release

Thank you for reporting

@alefragnani alefragnani added this to the April 2021 milestone May 13, 2021
@ciscoheat
Copy link
Author

Hi, no problem, I understand completely about busy times! Thanks for fixing the problem and thank you for a great extension!

@alefragnani
Copy link
Owner

Thank you for your understanding. I'm glad you like the extension 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants