-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example from README is not working #5
Comments
Hi, do you mind posting a reproducible repository or a code sandbox? |
@albingroen not sure whats the difference (except sandbox is JS and local is TS) here but I couldn't reproduce it over there Im not sure why I getting this error but maybe a bit of a research on what is the root cause of such an error can help us here |
I think it might be a React 18 issue. The sandbox seems to be using v17. Which version are you using? |
@albingroen Getting the exact same error here on React 17.0.2. Will try to reproduce in sandbox. |
Are you using create-react-app? |
@honzasusek Yeah, version |
@albingroen just mentioned it in the initial comment. I assume that the issue comes from parts in the code that are not backward compatible with react 17 ... |
For some weird reason, it works in codesandbox but not locally. Just tried downloading the zip and running it, but I'm running in to the same issue... |
@albingroen any progress here? do you need help? |
Not really any progress. Would love some help! |
@albingroen Not sure if this will help, but I just copied the package contents over to our repo, fixed the imports and it seems to be running just fine like that. Could this be a build-related issue? That might explain why codesandbox is working fine with the same setup. |
Hmm, that sounds really weird... |
@honzasusek Do you mind putting up that repo or inviting me to it so I can see it? |
@albingroen I'm afraid that isn't possible, but I think I could at least share our |
@honzasusek Alright, you can DM me here |
@albingroen no twitter account, sorry, sent you an email instead 👴 |
I was able to reproduce on a simple CRA project:
Then add the code from the readme into the app. |
Also, I'm adding these tags so people will find this issue easily:
|
Having same issue with React 18 on local machine. It is not working and throwing
|
It seems there is an ongoing discussion about React 18 and Transition component compatibility. I see react-cmdk using Transition component. Check the details here. |
I don't have the capacity to solve this, unfortunately, so I will close this for now :/ |
facing the same issue as well, also was working on codesandbox |
Im using create react app v5.0.1 with react v17.0.2 and getting
![image](https://user-images.githubusercontent.com/11806915/173474254-da2c6262-a97b-49dc-ac83-0510593a8bcc.png)
The text was updated successfully, but these errors were encountered: