Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executable for windows? #13

Open
Pkcarreno opened this issue Jan 4, 2023 · 9 comments
Open

executable for windows? #13

Pkcarreno opened this issue Jan 4, 2023 · 9 comments

Comments

@Pkcarreno
Copy link

No description provided.

@albingroen
Copy link
Owner

I unfortunately don't have Windows PC to test the app on :/

@Pkcarreno
Copy link
Author

I have windows, I can test it, but I don't know much about tauri

@albingroen
Copy link
Owner

I think if you fork, clone, run npm install and then npm run tauri build you should get a windows executable!

@Pkcarreno
Copy link
Author

I see, I will try

@Pkcarreno
Copy link
Author

For some reason while building failed and show this:

error: failed to run custom build command for `webview2-com-sys v0.19.0`

Caused by:
  process didn't exit successfully: `C:\Users\pedro\Downloads\notary-main\src-tauri\target\release\build\webview2-com-sys-883b5e057129b0cb\build-script-build` (exit code: 1)
  --- stdout
  cargo:rustc-link-search=native=C:\Users\pedro\Downloads\notary-main\src-tauri\target\release\build\webview2-com-sys-07992b1839d5620c\out\x64

  --- stderr
  Copy from "C:\\Users\\pedro\\.cargo\\registry\\src\\github.com-1ecc6299db9ec823\\webview2-com-sys-0.19.0\\arm64\\WebView2Loader.dll" -> "C:\\Users\\pedro\\Downloads\\notary-main\\src-tauri\\target\\release\\build\\webview2-com-sys-07992b1839d5620c\\out\\arm64\\WebView2Loader.dll"
  Copy from "C:\\Users\\pedro\\.cargo\\registry\\src\\github.com-1ecc6299db9ec823\\webview2-com-sys-0.19.0\\arm64\\WebView2Loader.dll.lib" -> "C:\\Users\\pedro\\Downloads\\notary-main\\src-tauri\\target\\release\\build\\webview2-com-sys-07992b1839d5620c\\out\\arm64\\WebView2Loader.dll.lib"
  Copy from "C:\\Users\\pedro\\.cargo\\registry\\src\\github.com-1ecc6299db9ec823\\webview2-com-sys-0.19.0\\arm64\\WebView2LoaderStatic.lib" -> "C:\\Users\\pedro\\Downloads\\notary-main\\src-tauri\\target\\release\\build\\webview2-com-sys-07992b1839d5620c\\out\\arm64\\WebView2LoaderStatic.lib"
  Copy from "C:\\Users\\pedro\\.cargo\\registry\\src\\github.com-1ecc6299db9ec823\\webview2-com-sys-0.19.0\\x64\\WebView2Loader.dll" -> "C:\\Users\\pedro\\Downloads\\notary-main\\src-tauri\\target\\release\\build\\webview2-com-sys-07992b1839d5620c\\out\\x64\\WebView2Loader.dll"
  Copy from "C:\\Users\\pedro\\.cargo\\registry\\src\\github.com-1ecc6299db9ec823\\webview2-com-sys-0.19.0\\x64\\WebView2Loader.dll.lib" -> "C:\\Users\\pedro\\Downloads\\notary-main\\src-tauri\\target\\release\\build\\webview2-com-sys-07992b1839d5620c\\out\\x64\\WebView2Loader.dll.lib"
  Copy from "C:\\Users\\pedro\\.cargo\\registry\\src\\github.com-1ecc6299db9ec823\\webview2-com-sys-0.19.0\\x64\\WebView2LoaderStatic.lib" -> "C:\\Users\\pedro\\Downloads\\notary-main\\src-tauri\\target\\release\\build\\webview2-com-sys-07992b1839d5620c\\out\\x64\\WebView2LoaderStatic.lib"
  Copy from "C:\\Users\\pedro\\.cargo\\registry\\src\\github.com-1ecc6299db9ec823\\webview2-com-sys-0.19.0\\x86\\WebView2Loader.dll" -> "C:\\Users\\pedro\\Downloads\\notary-main\\src-tauri\\target\\release\\build\\webview2-com-sys-07992b1839d5620c\\out\\x86\\WebView2Loader.dll"
  Copy from "C:\\Users\\pedro\\.cargo\\registry\\src\\github.com-1ecc6299db9ec823\\webview2-com-sys-0.19.0\\x86\\WebView2Loader.dll.lib" -> "C:\\Users\\pedro\\Downloads\\notary-main\\src-tauri\\target\\release\\build\\webview2-com-sys-07992b1839d5620c\\out\\x86\\WebView2Loader.dll.lib"
  Copy from "C:\\Users\\pedro\\.cargo\\registry\\src\\github.com-1ecc6299db9ec823\\webview2-com-sys-0.19.0\\x86\\WebView2LoaderStatic.lib" -> "C:\\Users\\pedro\\Downloads\\notary-main\\src-tauri\\target\\release\\build\\webview2-com-sys-07992b1839d5620c\\out\\x86\\WebView2LoaderStatic.lib"
  Error: Io(Error { kind: NotFound, message: "program not found" })
warning: build failed, waiting for other jobs to finish...
       Error failed to build app: failed to build app

@albingroen
Copy link
Owner

It seems you need some setup for building on Windows to work!
https://tauri.app/v1/guides/getting-started/prerequisites/#setting-up-windows

@Pkcarreno
Copy link
Author

Hey @albingroen

Sorry for the long wait. I recently came back to this project and this time I was able to build it.

I had to solve a minor issue related to the icons and it works properly in windows.
image

Also, I compiled it on my Linux machine (Fedora with Gnome) and it works as expected.
Screenshot from 2023-10-08 20-24-44

Without code changes it works fine, maybe a visual change like integrating the title bar in the app would improve the experience. And in the case of Linux it is not picking up the dark mode.

If you want, I can experiment with solving these issues and I can help you porting a version for both platforms (maybe with Github actions?).

btw, first time I try it and it looks pretty nice and the integration with vim bindings is amazing!

@albingroen
Copy link
Owner

Hey, this looks super cool! I would definitely appreciate your help on this, since I have neither a Windows or Linux machine

@Pkcarreno
Copy link
Author

Awesome, how should we proceed?
Actually I already created a fork and made the icon changes I told you about.

I was researching to integrate the title bar in the app but I didn't get a simple way to do it in tauri 1, I got this package but it works only in tauri 2.

I also got this cross-platform compilation script, based on the official tauri documentation, I'm testing it in my repo to see how it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants