Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor]: Typo in ~/README.md #156

Closed
marktoh opened this issue May 16, 2024 · 2 comments · Fixed by #158
Closed

[minor]: Typo in ~/README.md #156

marktoh opened this issue May 16, 2024 · 2 comments · Fixed by #158

Comments

@marktoh
Copy link
Contributor

marktoh commented May 16, 2024

Description

Going through the README.md, I found that there was a full stop missing for one of the sentences.

Preview Fix
Screenshot 2024-05-16 at 9 27 59 PM Screenshot 2024-05-16 at 9 27 34 PM

I tried making a PR for this but ran into some permissions issue.

 git push --set-upstream origin fix-root-readme-typo
remote: Permission to alan2207/bulletproof-react.git denied to marktoh.
fatal: unable to access 'https://github.com/alan2207/bulletproof-react.git/': The requested URL returned error: 403

It's a small one but hope it helps!
@marktoh marktoh changed the title Typo in Root README.md [minor] [minor]: Typo in Root README.md May 16, 2024
@seantcanavan
Copy link

you have to create a fork of the original repo and push your changes to the fork then open a PR from fork to here. the permission error you're seeing is likely because you're trying to push directly against this repo which you don't have permission to.

mohamadboufi678 referenced this issue May 17, 2024
@alan2207
skip ci when only docs change have been made
513d8bd
@marktoh marktoh mentioned this issue May 17, 2024
Merged
@marktoh
Copy link
Contributor Author

marktoh commented May 17, 2024 •
edited
Loading

@seantcanavan Thank you. I created a PR here, #158. Please let me know if that works.

@marktoh marktoh changed the title [minor]: Typo in Root README.md [minor]: Typo in ~/README.md May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[minor]: Typo in ~/README.md and docs/security.md marktoh/bulletproof-react
2 participants
@seantcanavan @marktoh