Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up test logging output #1447

Merged
merged 1 commit into from
Jun 7, 2018
Merged

Tidy up test logging output #1447

merged 1 commit into from
Jun 7, 2018

Conversation

tangrammer
Copy link
Contributor

specifically this output

09:17:22.976 [main] ERROR akvo.lumen.import - #error {
 :cause Invalid csv file. Varying number of columns
 :data {}
 :via
 [{:type clojure.lang.ExceptionInfo
   :message Invalid csv file. Varying number of columns
   :data {}
   :at [clojure.core$ex_info invokeStatic core.clj 4739]}]
 :trace
 [[clojure.core$ex_info invokeStatic core.clj 4739]
  [clojure.core$ex_info invoke core.clj 4739]
  [akvo.lumen.import.csv$get_column_count invokeStatic csv.clj 72]
  [akvo.lumen.import.csv$get_column_count invoke csv.clj 68]
  [akvo.lumen.import.csv$csv_importer invokeStatic csv.clj 77]
  [akvo.lumen.import.csv$csv_importer invoke csv.clj 74]
  [akvo.lumen.import.csv$eval9604$fn__9606 invoke csv.clj 100]
  [clojure.lang.MultiFn invoke MultiFn.java 233]
  [akvo.lumen.import$do_import invokeStatic import.clj 79]
  [akvo.lumen.import$do_import invoke import.clj 72]
  [akvo.lumen.test_utils$import_file invokeStatic test_utils.clj 46]
  [akvo.lumen.test_utils$import_file invoke test_utils.clj 34]
  [akvo.lumen.import.csv_test$fn__18292 invokeStatic csv_test.clj 53]
  [akvo.lumen.import.csv_test$fn__18292 invoke csv_test.clj 49]
  [clojure.test$test_var$fn__9209 invoke test.clj 716]
  [clojure.test$test_var invokeStatic test.clj 716]
  [clojure.test$test_var invoke test.clj 707]
  [clojure.test$test_vars$fn__9235$fn__9240 invoke test.clj 734]
  [clojure.test$default_fixture invokeStatic test.clj 686]
  [clojure.test$default_fixture invoke test.clj 682]
  [clojure.test$test_vars$fn__9235 invoke test.clj 734]
  [akvo.lumen.fixtures$error_tracker_fixture invokeStatic fixtures.clj 50]
  [akvo.lumen.fixtures$error_tracker_fixture invoke fixtures.clj 46]
  [clojure.test$compose_fixtures$fn__9203$fn__9204 invoke test.clj 693]
  [akvo.lumen.fixtures$tenant_conn_fixture invokeStatic fixtures.clj 41]
  [akvo.lumen.fixtures$tenant_conn_fixture invoke fixtures.clj 36]
  [clojure.test$compose_fixtures$fn__9203$fn__9204 invoke test.clj 693]
  [clojure.test$default_fixture invokeStatic test.clj 686]
  [clojure.test$default_fixture invoke test.clj 682]
  [clojure.test$compose_fixtures$fn__9203 invoke test.clj 693]
  [clojure.test$compose_fixtures$fn__9203 invoke test.clj 693]
  [clojure.test$test_vars invokeStatic test.clj 730]
  [clojure.test$test_all_vars invokeStatic test.clj 736]
  [clojure.test$test_ns invokeStatic test.clj 757]
  [clojure.test$test_ns invoke test.clj 742]
  [user$eval244$fn__305 invoke form-init3969910229572090698.clj 1]
  [clojure.lang.AFn applyToHelper AFn.java 156]
  [clojure.lang.AFn applyTo AFn.java 144]
  [clojure.core$apply invokeStatic core.clj 659]
  [clojure.core$apply invoke core.clj 652]
  [leiningen.core.injected$compose_hooks$fn__174 doInvoke form-init3969910229572090698.clj 1]
  [clojure.lang.RestFn applyTo RestFn.java 137]
  [clojure.core$apply invokeStatic core.clj 657]
  [clojure.core$apply invoke core.clj 652]
  [leiningen.core.injected$run_hooks invokeStatic form-init3969910229572090698.clj 1]
  [leiningen.core.injected$run_hooks invoke form-init3969910229572090698.clj 1]
  [leiningen.core.injected$prepare_for_hooks$fn__179$fn__180 doInvoke form-init3969910229572090698.clj 1]
  [clojure.lang.RestFn applyTo RestFn.java 137]
  [clojure.lang.AFunction$1 doInvoke AFunction.java 29]
  [clojure.lang.RestFn invoke RestFn.java 408]
  [clojure.core$map$fn__5587 invoke core.clj 2747]
  [clojure.lang.LazySeq sval LazySeq.java 40]
  [clojure.lang.LazySeq seq LazySeq.java 49]
  [clojure.lang.Cons next Cons.java 39]
  [clojure.lang.RT next RT.java 706]
  [clojure.core$next__5108 invokeStatic core.clj 64]
  [clojure.core$reduce1 invokeStatic core.clj 936]
  [clojure.core$reduce1 invokeStatic core.clj 926]
  [clojure.core$merge_with invokeStatic core.clj 3051]
  [clojure.core$merge_with doInvoke core.clj 3043]
  [clojure.lang.RestFn applyTo RestFn.java 139]
  [clojure.core$apply invokeStatic core.clj 659]
  [clojure.test$run_tests invokeStatic test.clj 767]
  [clojure.test$run_tests doInvoke test.clj 767]
  [clojure.lang.RestFn applyTo RestFn.java 137]
  [clojure.core$apply invokeStatic core.clj 657]
  [clojure.core$apply invoke core.clj 652]
  [user$eval244$fn__317$fn__350 invoke form-init3969910229572090698.clj 1]
  [user$eval244$fn__317$fn__318 invoke form-init3969910229572090698.clj 1]
  [user$eval244$fn__317 invoke form-init3969910229572090698.clj 1]
  [user$eval244 invokeStatic form-init3969910229572090698.clj 1]
  [user$eval244 invoke form-init3969910229572090698.clj 1]
  [clojure.lang.Compiler eval Compiler.java 7062]
  [clojure.lang.Compiler eval Compiler.java 7052]
  [clojure.lang.Compiler load Compiler.java 7514]
  [clojure.lang.Compiler loadFile Compiler.java 7452]
  [clojure.main$load_script invokeStatic main.clj 278]
  [clojure.main$init_opt invokeStatic main.clj 280]
  [clojure.main$init_opt invoke main.clj 280]
  [clojure.main$initialize invokeStatic main.clj 311]
  [clojure.main$null_opt invokeStatic main.clj 345]
  [clojure.main$null_opt invoke main.clj 342]
  [clojure.main$main invokeStatic main.clj 424]
  [clojure.main$main doInvoke main.clj 387]
  [clojure.lang.RestFn applyTo RestFn.java 137]
  [clojure.lang.Var applyTo Var.java 702]
  [clojure.main main main.java 37]]}
  • Update release notes if necessary

specifically this output
```
09:17:22.976 [main] ERROR akvo.lumen.import - #error {
 :cause Invalid csv file. Varying number of columns
 :data {}
 :via
 [{:type clojure.lang.ExceptionInfo
   :message Invalid csv file. Varying number of columns
   :data {}
   :at [clojure.core$ex_info invokeStatic core.clj 4739]}]
 :trace
 [[clojure.core$ex_info invokeStatic core.clj 4739]
  [clojure.core$ex_info invoke core.clj 4739]
  [akvo.lumen.import.csv$get_column_count invokeStatic csv.clj 72]
  [akvo.lumen.import.csv$get_column_count invoke csv.clj 68]
  [akvo.lumen.import.csv$csv_importer invokeStatic csv.clj 77]
  [akvo.lumen.import.csv$csv_importer invoke csv.clj 74]
  [akvo.lumen.import.csv$eval9604$fn__9606 invoke csv.clj 100]
  [clojure.lang.MultiFn invoke MultiFn.java 233]
  [akvo.lumen.import$do_import invokeStatic import.clj 79]
  [akvo.lumen.import$do_import invoke import.clj 72]
  [akvo.lumen.test_utils$import_file invokeStatic test_utils.clj 46]
  [akvo.lumen.test_utils$import_file invoke test_utils.clj 34]
  [akvo.lumen.import.csv_test$fn__18292 invokeStatic csv_test.clj 53]
  [akvo.lumen.import.csv_test$fn__18292 invoke csv_test.clj 49]
  [clojure.test$test_var$fn__9209 invoke test.clj 716]
  [clojure.test$test_var invokeStatic test.clj 716]
  [clojure.test$test_var invoke test.clj 707]
  [clojure.test$test_vars$fn__9235$fn__9240 invoke test.clj 734]
  [clojure.test$default_fixture invokeStatic test.clj 686]
  [clojure.test$default_fixture invoke test.clj 682]
  [clojure.test$test_vars$fn__9235 invoke test.clj 734]
  [akvo.lumen.fixtures$error_tracker_fixture invokeStatic fixtures.clj 50]
  [akvo.lumen.fixtures$error_tracker_fixture invoke fixtures.clj 46]
  [clojure.test$compose_fixtures$fn__9203$fn__9204 invoke test.clj 693]
  [akvo.lumen.fixtures$tenant_conn_fixture invokeStatic fixtures.clj 41]
  [akvo.lumen.fixtures$tenant_conn_fixture invoke fixtures.clj 36]
  [clojure.test$compose_fixtures$fn__9203$fn__9204 invoke test.clj 693]
  [clojure.test$default_fixture invokeStatic test.clj 686]
  [clojure.test$default_fixture invoke test.clj 682]
  [clojure.test$compose_fixtures$fn__9203 invoke test.clj 693]
  [clojure.test$compose_fixtures$fn__9203 invoke test.clj 693]
  [clojure.test$test_vars invokeStatic test.clj 730]
  [clojure.test$test_all_vars invokeStatic test.clj 736]
  [clojure.test$test_ns invokeStatic test.clj 757]
  [clojure.test$test_ns invoke test.clj 742]
  [user$eval244$fn__305 invoke form-init3969910229572090698.clj 1]
  [clojure.lang.AFn applyToHelper AFn.java 156]
  [clojure.lang.AFn applyTo AFn.java 144]
  [clojure.core$apply invokeStatic core.clj 659]
  [clojure.core$apply invoke core.clj 652]
  [leiningen.core.injected$compose_hooks$fn__174 doInvoke form-init3969910229572090698.clj 1]
  [clojure.lang.RestFn applyTo RestFn.java 137]
  [clojure.core$apply invokeStatic core.clj 657]
  [clojure.core$apply invoke core.clj 652]
  [leiningen.core.injected$run_hooks invokeStatic form-init3969910229572090698.clj 1]
  [leiningen.core.injected$run_hooks invoke form-init3969910229572090698.clj 1]
  [leiningen.core.injected$prepare_for_hooks$fn__179$fn__180 doInvoke form-init3969910229572090698.clj 1]
  [clojure.lang.RestFn applyTo RestFn.java 137]
  [clojure.lang.AFunction$1 doInvoke AFunction.java 29]
  [clojure.lang.RestFn invoke RestFn.java 408]
  [clojure.core$map$fn__5587 invoke core.clj 2747]
  [clojure.lang.LazySeq sval LazySeq.java 40]
  [clojure.lang.LazySeq seq LazySeq.java 49]
  [clojure.lang.Cons next Cons.java 39]
  [clojure.lang.RT next RT.java 706]
  [clojure.core$next__5108 invokeStatic core.clj 64]
  [clojure.core$reduce1 invokeStatic core.clj 936]
  [clojure.core$reduce1 invokeStatic core.clj 926]
  [clojure.core$merge_with invokeStatic core.clj 3051]
  [clojure.core$merge_with doInvoke core.clj 3043]
  [clojure.lang.RestFn applyTo RestFn.java 139]
  [clojure.core$apply invokeStatic core.clj 659]
  [clojure.test$run_tests invokeStatic test.clj 767]
  [clojure.test$run_tests doInvoke test.clj 767]
  [clojure.lang.RestFn applyTo RestFn.java 137]
  [clojure.core$apply invokeStatic core.clj 657]
  [clojure.core$apply invoke core.clj 652]
  [user$eval244$fn__317$fn__350 invoke form-init3969910229572090698.clj 1]
  [user$eval244$fn__317$fn__318 invoke form-init3969910229572090698.clj 1]
  [user$eval244$fn__317 invoke form-init3969910229572090698.clj 1]
  [user$eval244 invokeStatic form-init3969910229572090698.clj 1]
  [user$eval244 invoke form-init3969910229572090698.clj 1]
  [clojure.lang.Compiler eval Compiler.java 7062]
  [clojure.lang.Compiler eval Compiler.java 7052]
  [clojure.lang.Compiler load Compiler.java 7514]
  [clojure.lang.Compiler loadFile Compiler.java 7452]
  [clojure.main$load_script invokeStatic main.clj 278]
  [clojure.main$init_opt invokeStatic main.clj 280]
  [clojure.main$init_opt invoke main.clj 280]
  [clojure.main$initialize invokeStatic main.clj 311]
  [clojure.main$null_opt invokeStatic main.clj 345]
  [clojure.main$null_opt invoke main.clj 342]
  [clojure.main$main invokeStatic main.clj 424]
  [clojure.main$main doInvoke main.clj 387]
  [clojure.lang.RestFn applyTo RestFn.java 137]
  [clojure.lang.Var applyTo Var.java 702]
  [clojure.main main main.java 37]]}
```
@tangrammer tangrammer requested a review from kardan June 6, 2018 09:45
Copy link
Contributor

@kardan kardan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me

@kardan kardan merged commit 16d490e into develop Jun 7, 2018
@tangrammer tangrammer deleted the tangrammer-patch-1 branch June 19, 2018 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants