Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset api response has no rows #1534

Closed
gabemart opened this issue Jul 5, 2018 · 0 comments
Closed

Dataset api response has no rows #1534

gabemart opened this issue Jul 5, 2018 · 0 comments

Comments

@gabemart
Copy link
Contributor

gabemart commented Jul 5, 2018

In the recent refactor of the dataset api response, there's a bug where no rows are included in the response

gabemart added a commit that referenced this issue Jul 5, 2018
dlebrero added a commit that referenced this issue Jul 9, 2018
This was the logic before the last refactoring
dlebrero added a commit that referenced this issue Jul 9, 2018
[#1534] Include rows in dataset api response
@dlebrero dlebrero closed this as completed Jul 9, 2018
finnfiddle added a commit that referenced this issue Jul 9, 2018
…-in-visualisations-#1494

* develop: (33 commits)
  [#1534] Removing "hidden" columns from dataset response
  [#1534] Remove unnecessary rows key
  [#1534] Include rows in dataset api response
  #778 show author email if no name is set - library page
  Cannot go back to white colour in raster theme #1426
  Hover area is not equal to hit area in the Lumen library #1401
  User defined labels do not change for Bar charts #1516
  The product link should lead to an information page #1442
  #778 library meta fixes 3
  #1513 dashboard restyling fixes
  [#1525] New polyfills
  #1513 refactor how last updated date is retrieved and rendered
  [#1443] Revert: Breaking test to test CI
  [#1443] Breaking test to test CI
  [#1443] Recording test results in CI
  [#1443] Not running groupmod or usermod for Macs
  [#1443] Renaming env vars so they are picked up by Cypress
  Remove black border around visualisations in dashboards #1513
  [#1443] Fixing docker-compose cmd
  [#1443] Pass env vars to Cypress container
  ...

# Conflicts:
#	client/src/components/dashboard/DashboardViewer.jsx
#	client/src/index-pub.jsx
@tangrammer tangrammer added the bug label Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants