Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IE10 polyfill issues #1525

Closed
gabemart opened this issue Jul 4, 2018 · 0 comments
Closed

IE10 polyfill issues #1525

gabemart opened this issue Jul 4, 2018 · 0 comments
Assignees
@finnfiddle
Milestone
Dainty Deneb

Comments

@gabemart
Copy link
Contributor

gabemart commented Jul 4, 2018

There are two related issues

The first is that we need to update the polyfills we check for and load when required

The second is that browsers which require polyfills don't work with our current dev environment, because the dev environment hot reloading system injects code es6/es7 code which is run before the polyfills are loaded. This isn't a show-stopper, but it makes it less convenient to test with older browsers locally, and it would be nice to fix this
gabemart added a commit that referenced this issue Jul 4, 2018
@gabemart
[#1525] Add new polyfills
031a4e8
gabemart added a commit that referenced this issue Jul 4, 2018
@gabemart
[#1525] New polyfills
5a4f388
finnfiddle added a commit that referenced this issue Jul 5, 2018
@finnfiddle
Merge pull request #1527 from akvo/issue/1525-new-polyfills-2
84bc40f 
[#1525] New polyfills
finnfiddle added a commit that referenced this issue Jul 9, 2018
@finnfiddle
Merge branch 'develop' into Switch-between-interactive-and-print-mode…
e93ea92 
…-in-visualisations-#1494

* develop: (33 commits)
  [#1534] Removing "hidden" columns from dataset response
  [#1534] Remove unnecessary rows key
  [#1534] Include rows in dataset api response
  #778 show author email if no name is set - library page
  Cannot go back to white colour in raster theme #1426
  Hover area is not equal to hit area in the Lumen library #1401
  User defined labels do not change for Bar charts #1516
  The product link should lead to an information page #1442
  #778 library meta fixes 3
  #1513 dashboard restyling fixes
  [#1525] New polyfills
  #1513 refactor how last updated date is retrieved and rendered
  [#1443] Revert: Breaking test to test CI
  [#1443] Breaking test to test CI
  [#1443] Recording test results in CI
  [#1443] Not running groupmod or usermod for Macs
  [#1443] Renaming env vars so they are picked up by Cypress
  Remove black border around visualisations in dashboards #1513
  [#1443] Fixing docker-compose cmd
  [#1443] Pass env vars to Cypress container
  ...

# Conflicts:
#	client/src/components/dashboard/DashboardViewer.jsx
#	client/src/index-pub.jsx
finnfiddle added a commit that referenced this issue Jul 10, 2018
@finnfiddle
IE10 polyfill issues #1525
06422a0
finnfiddle added a commit that referenced this issue Jul 10, 2018
@finnfiddle
Merge pull request #1539 from akvo/IE10-polyfill-issues-#1525
473bc01 
IE10 polyfill issues #1525
finnfiddle added a commit that referenced this issue Jul 10, 2018
@finnfiddle
IE10 polyfill issues #1525
d05ed1b
finnfiddle added a commit that referenced this issue Jul 10, 2018
@finnfiddle
IE10 polyfill issues #1525 - raf polyfill
a0bdd49
finnfiddle added a commit that referenced this issue Jul 10, 2018
@finnfiddle
#1525 raf from devdeps -> deps
b21c019
finnfiddle added a commit that referenced this issue Jul 10, 2018
@finnfiddle
Merge pull request #1541 from akvo/IE10-polyfill-issues-#1525---2
c5714ce 
IE10 polyfill issues #1525
finnfiddle added a commit that referenced this issue Jul 10, 2018
@finnfiddle
#1525 reordered polyfill import
9739368
finnfiddle added a commit that referenced this issue Jul 11, 2018
@finnfiddle
#1525 fixed linting
a736de9
finnfiddle added a commit that referenced this issue Jul 11, 2018
@finnfiddle
Merge pull request #1544 from akvo/IE10-polyfill-issues-#1525---3
a5f24c8 
#1525 reordered polyfill import
@finnfiddle finnfiddle self-assigned this Jul 12, 2018
@finnfiddle finnfiddle added this to the Dainty Deneb milestone Jul 12, 2018
finnfiddle added a commit that referenced this issue Jul 13, 2018
@finnfiddle
#1525 debugging polyfills
44a11f2
finnfiddle added a commit that referenced this issue Jul 13, 2018
@finnfiddle
Merge pull request #1553 from akvo/#1525-polyfill-debugging-1
bdd3989 
#1525 debugging polyfills
finnfiddle added a commit that referenced this issue Jul 13, 2018
@finnfiddle
IE10 polyfill issues #1525
c346681
finnfiddle added a commit that referenced this issue Jul 13, 2018
@finnfiddle
IE10 polyfill issues #1525 refactoring
8b87665
finnfiddle added a commit that referenced this issue Jul 13, 2018
@finnfiddle
Merge pull request #1557 from akvo/IE10-polyfill-issues-#1525-4
9e7a3df 
IE10 polyfill issues #1525
finnfiddle added a commit that referenced this issue Jul 16, 2018
@finnfiddle
#1525 testing polyfills
b2e1140
finnfiddle added a commit that referenced this issue Jul 16, 2018
@finnfiddle
#1525 polyfill restructuring
15855d6
finnfiddle added a commit that referenced this issue Jul 16, 2018
@finnfiddle
#1525 fixed linting
8ee927a
finnfiddle added a commit that referenced this issue Jul 16, 2018
@finnfiddle
Merge pull request #1563 from akvo/IE-polyfill-issues-#1525-5
f5016e2 
#1525 polyfill restructuring
finnfiddle added a commit that referenced this issue Jul 16, 2018
@finnfiddle
#1525 cleaning up console.logs
6aca790
finnfiddle added a commit that referenced this issue Jul 16, 2018
@finnfiddle
Merge pull request #1565 from akvo/#1525-cleaning-up-console-logs
cdc2b97 
#1525 cleaning up console.logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@finnfiddle finnfiddle

Labels
None yet
Projects
None yet
Milestone
Dainty Deneb
Development

No branches or pull requests
4 participants
@tangrammer @gabemart @finnfiddle @janagombitova