Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): ng-add schematic #942

Merged
merged 53 commits into from
Nov 15, 2018
Merged

Conversation

Tibing
Copy link
Member

@Tibing Tibing commented Oct 25, 2018

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

  • ng-add schematics was added
  • documentation was updated
  • the build flow was slightly modified, so, please, check it

Angular CLI no longer support capability specify project in any place between options.
We have to pass it as first argument now.
@Tibing Tibing requested review from nnixaa and yggg October 25, 2018 16:04
Copy link
Contributor

@yggg yggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add usage docs.

Copy link
Contributor

@yggg yggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Angular utilities published under @schematics/angular. Please, install and remove all copied code from src/framework/theme/schematics/util/**.

@Tibing
Copy link
Member Author

Tibing commented Nov 14, 2018

@yggg, could you please check again updated installation guide

@Tibing Tibing merged commit 5d5a874 into akveo:master Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants