Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): don't import child routes as it will rewrite the app routes #920

Merged
merged 3 commits into from
Oct 23, 2018

Conversation

nnixaa
Copy link
Collaborator

@nnixaa nnixaa commented Oct 17, 2018

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

@nnixaa nnixaa requested a review from yggg October 17, 2018 16:48
Copy link
Contributor

@yggg yggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we need to mention predefined routes in the documentation.
https://akveo.github.io/nebular/docs/auth/installation#enable-auth-components

Copy link
Contributor

@yggg yggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we need to mention predefined routes in the documentation.
https://akveo.github.io/nebular/docs/auth/installation#enable-auth-components

Copy link
Contributor

@yggg yggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we need to mention predefined routes in the documentation.
https://akveo.github.io/nebular/docs/auth/installation#enable-auth-components

@nnixaa nnixaa merged commit d054a73 into master Oct 23, 2018
@nnixaa nnixaa deleted the fix/fix-auth-routes branch October 25, 2018 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants