Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): show day in today's date #899

Merged
merged 3 commits into from
Oct 16, 2018
Merged

fix(theme): show day in today's date #899

merged 3 commits into from
Oct 16, 2018

Conversation

lexzhukov
Copy link
Contributor

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Fix #615

@lexzhukov lexzhukov requested a review from nnixaa October 12, 2018 12:25
@Tibing
Copy link
Member

Tibing commented Oct 15, 2018

I think the date has to be rendered considering custom locale. Maybe, we will just use default Angular date pipe for this purpose?

@Tibing
Copy link
Member

Tibing commented Oct 15, 2018

Also, I'm not sure we need custom pipe at all. Could we use default Angular date pipe instead? What do you think?

@lexzhukov
Copy link
Contributor Author

Also, I'm not sure we need custom pipe at all. Could we use default Angular date pipe instead? What do you think?

I agree. It's good practice.

@nnixaa nnixaa merged commit e023aa3 into akveo:master Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calendar: Todayis not showing the day
3 participants