Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/overlay components providers #858

Merged
merged 5 commits into from
Oct 3, 2018

Conversation

Tibing
Copy link
Member

@Tibing Tibing commented Oct 3, 2018

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Nebular Overlays now have to work properly without explicit importing NbOverlayModule in lazy loaded modules

Closes #854

@Tibing Tibing requested a review from nnixaa October 3, 2018 05:44
@codecov
Copy link

codecov bot commented Oct 3, 2018

Codecov Report

Merging #858 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #858      +/-   ##
==========================================
+ Coverage   76.94%   76.96%   +0.02%     
==========================================
  Files         201      201              
  Lines        5907     5913       +6     
  Branches      449      449              
==========================================
+ Hits         4545     4551       +6     
+ Misses       1260     1258       -2     
- Partials      102      104       +2
Impacted Files Coverage Δ
...ramework/theme/components/dialog/dialog.service.ts 88.7% <100%> (+0.18%) ⬆️
...ramework/theme/components/toastr/toastr.service.ts 72.61% <100%> (+0.32%) ⬆️
.../theme/components/cdk/overlay/overlay-container.ts 93.1% <100%> (+1.1%) ⬆️
.../framework/theme/components/cdk/overlay/mapping.ts 89.88% <0%> (-1.13%) ⬇️
...framework/theme/components/toastr/toastr.module.ts 90.9% <0%> (+9.09%) ⬆️

@nnixaa nnixaa merged commit 843a6c6 into akveo:master Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix playground/docs and forRoot issues
2 participants