Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): remove bootstrap #738

Merged
merged 17 commits into from
Sep 25, 2018
Merged

feat(auth): remove bootstrap #738

merged 17 commits into from
Sep 25, 2018

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Sep 20, 2018

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

@yggg yggg added the WIP label Sep 20, 2018
@yggg yggg requested a review from nnixaa September 20, 2018 13:32
@codecov
Copy link

codecov bot commented Sep 20, 2018

Codecov Report

Merging #738 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #738      +/-   ##
==========================================
- Coverage   76.78%   76.77%   -0.02%     
==========================================
  Files         198      198              
  Lines        5717     5718       +1     
  Branches      433      433              
==========================================
  Hits         4390     4390              
- Misses       1233     1234       +1     
  Partials       94       94
Impacted Files Coverage Δ
...auth/components/auth-block/auth-block.component.ts 100% <ø> (ø) ⬆️
src/framework/auth/components/auth.component.ts 44.44% <ø> (ø) ⬆️
...framework/auth/components/login/login.component.ts 21.95% <0%> (-0.55%) ⬇️

@yggg yggg removed the WIP label Sep 24, 2018
angular.json Show resolved Hide resolved
color: nb-theme(color-fg);
font-weight: bold;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a variable for bold


.icon {
font-size: 2rem;
font-weight: bold;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variable

BREAKING CHANGE:

Remove bootstrap from peer dependencies. If you need bootstrap support you can use "bootstrap" package.
fixes IE "Multiple definitions of a property not allowed in strict mode"
@nnixaa nnixaa merged commit b585490 into akveo:master Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants