Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/toastr #692

Merged
merged 44 commits into from
Sep 11, 2018
Merged

Feature/toastr #692

merged 44 commits into from
Sep 11, 2018

Conversation

Tibing
Copy link
Member

@Tibing Tibing commented Sep 3, 2018

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #667

Tibing and others added 30 commits August 27, 2018 16:52
@Tibing Tibing requested a review from yggg September 3, 2018 14:17
@codecov
Copy link

codecov bot commented Sep 11, 2018

Codecov Report

Merging #692 into master will decrease coverage by 1.27%.
The diff coverage is 59.94%.

@@            Coverage Diff             @@
##           master     #692      +/-   ##
==========================================
- Coverage   73.64%   72.36%   -1.28%     
==========================================
  Files         169      168       -1     
  Lines        4542     4632      +90     
  Branches      348      358      +10     
==========================================
+ Hits         3345     3352       +7     
- Misses       1125     1213      +88     
+ Partials       72       67       -5
Impacted Files Coverage Δ
.../components/context-menu/context-menu.component.ts 85.71% <100%> (ø) ⬆️
...amework/theme/components/popover/popover.module.ts 100% <100%> (ø) ⬆️
...framework/theme/components/search/search.module.ts 100% <100%> (ø) ⬆️
...rc/framework/theme/components/cdk/overlay/index.ts 100% <100%> (ø) ⬆️
src/framework/theme/services/theme.service.ts 92.85% <100%> (ø) ⬆️
...ork/theme/components/cdk/adapter/adapter.module.ts 100% <100%> (ø) ⬆️
...eme/components/context-menu/context-menu.module.ts 100% <100%> (ø) ⬆️
src/framework/theme/components/cdk/index.ts 100% <100%> (ø) ⬆️
...work/theme/components/popover/popover.component.ts 100% <100%> (ø) ⬆️
...framework/theme/components/toastr/toastr-config.ts 100% <100%> (ø)
... and 41 more

@Tibing Tibing force-pushed the feature/toastr branch 2 times, most recently from 81f9931 to 704cb71 Compare September 11, 2018 14:34
@nnixaa nnixaa merged commit 29e4fef into akveo:master Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New component - toast
3 participants